Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only return formatted date if it's set #198

Merged
merged 3 commits into from
Feb 27, 2020
Merged

fix: only return formatted date if it's set #198

merged 3 commits into from
Feb 27, 2020

Conversation

greatislander
Copy link
Collaborator

Description

For resources without publication dates, don't show the publication date.

Steps to test

  1. Find a resource that doesn't have a publication date set.
  2. View it in card and single resource views.

Expected behavior: Publication date is not shown.

Additional information

Not applicable.

Related issues

Not applicable.

@greatislander greatislander added the enhancement New feature or request label Feb 26, 2020
@greatislander greatislander added this to the 1.0.0-alpha.2 milestone Feb 26, 2020
@greatislander greatislander requested a review from jhung February 26, 2020 20:37
@greatislander greatislander self-assigned this Feb 26, 2020
@greatislander greatislander merged commit 30d77d7 into dev Feb 27, 2020
@greatislander greatislander deleted the fix/optional-publication-dates branch February 27, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhung jhung jhung approved these changes

Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0-alpha.2
Development

Successfully merging this pull request may close these issues.
2 participants
@greatislander @jhung